Disable startup assembly support for MSBuild integration #34034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
GenerateFactories
branch
from
54698c0
to
e691179
Compare
Allow DbContextAttribute to be used to find the referenced context types
AndriySvyryd
force-pushed
the
LimitStartup
branch
from
ee3398c
to
4e64131
Compare
ajcvickers
reviewed
Jun 20, 2024
| @@ -474,8 +474,19 @@ where i.IsGenericType | |||
| } | |||
| } | |||
|
|
|||
| // Look for DbContext classes registered in the service provider | |||
| // Look for DbContextAttribute on the assembly | |||
| var appServices = _appServicesFactory.Create(_args); | |||
There was a problem hiding this comment.
I think this suffers from the same technicality as #27322. That is, even if we find a context by this mechanism, it could actually be a different one than would have been returned by running service discovery, if it were working correctly at design time. So we could end up working with the "wrong" context type. I personally think this is very unlikely, but it has been the sticking point on #27322 over the years.
There was a problem hiding this comment.
Yes. I plan to fix #27322 separately.
Also, I want to discuss this change in a design meeting.
ajcvickers
approved these changes
Jun 20, 2024
|
I disabled auto merge, please check in after #34043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
DbContextAttributeto be used to find the referenced context types